Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tie release of package to particular version of HYDRAD #146

Open
wtbarnes opened this issue Apr 13, 2021 · 1 comment
Open

Tie release of package to particular version of HYDRAD #146

wtbarnes opened this issue Apr 13, 2021 · 1 comment
Milestone

Comments

@wtbarnes
Copy link
Member

This will be very important once we start doing releases of the package. As we cannot go back and update a given release, it will be important to tie a particular version of pydrad to a particular version of HYDRAD that we know it will work with.

We can do this most easily by setting the hydrad_stripped_down function to clone from a specified commit hash that we know works (i.e. passes all tests) with pydrad. As new releases are made and there are additions to HYDRAD, we can update this commit hash.

We could keep the master branch always on the most recent HYDRAD commit hash and just set it on each release branch.

@wtbarnes wtbarnes added this to the 0.1 Release milestone Apr 13, 2021
@wtbarnes
Copy link
Member Author

There could be a kwarg to hydrad_stripped_down for specifying the commit hash to clone from to make this a bit more flexible.

I think the best way to proceed would be to do a major release for each new (breaking) version of HYDRAD and then to continue to backport bugfixes as needed. Again, every effort should be made to make things backwards compatible, but that won't always be possible/practical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant