Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove and ignore all config.h and .cfg files? #73

Open
wtbarnes opened this issue Jun 5, 2020 · 0 comments
Open

Remove and ignore all config.h and .cfg files? #73

wtbarnes opened this issue Jun 5, 2020 · 0 comments

Comments

@wtbarnes
Copy link
Member

wtbarnes commented Jun 5, 2020

I've noticed that each time a new PR is made, many of the config.h and *.cfg files also get committed/updated.

In a way, I don't see these as "real" commits as they are essentially just configuration files and are specific to a particularly instance of running the code rather than the state of the code as a whole. In this way, I'd suggest we remove these from the repo and add them to the .gitignore so they are not tracked by git but could still be present in your local repo without any issues.

I don't see this is as a problem as the user is always going to generate these, either using the GUI or pydrad, every time they want to run the code. This also eliminates the risk of accidentally using a stale configuration/header file and not realizing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant