Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove malloc.h in Forward Modeling code #12

Open
jwreep opened this issue May 4, 2018 · 4 comments
Open

Remove malloc.h in Forward Modeling code #12

jwreep opened this issue May 4, 2018 · 4 comments

Comments

@jwreep
Copy link
Member

jwreep commented May 4, 2018

In Forward_Model/source/:

forward.cpp, instrument.cpp, ion.cpp, loop.cpp, and strand.cpp each have <malloc.h> included, which will cause compilation errors on Mac or Linux (and certain compilers).

<malloc.h> can be replaced with <stdlib.h>, which should work on all operating systems.

@wtbarnes
Copy link
Member

wtbarnes commented May 9, 2018

Yeah I've also had an issue with this as well. In my experience, it tends to be an issue on macOS when you don't have the XCode developer tools installed.

@wtbarnes
Copy link
Member

wtbarnes commented May 9, 2018

This isn't just in the forward modeling code, but pops up in the "Radiation_Model" module as well.

@jwreep
Copy link
Member Author

jwreep commented May 10, 2018

These should be removed in the Radiation_Model in newer versions. I think the Forward_Model is the last place they show up.

@wtbarnes
Copy link
Member

Ah you're right. I am thinking of an older version of the Radiation Model code.

@wtbarnes wtbarnes changed the title Low priority: malloc.h in Forward Modeling code Remove malloc.h in Forward Modeling code Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants