Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images contained in .json files #17

Open
LukasMosser opened this issue Jun 20, 2020 · 3 comments
Open

Images contained in .json files #17

LukasMosser opened this issue Jun 20, 2020 · 3 comments

Comments

@LukasMosser
Copy link

I have a question regarding the assets.zip.

It looks like the json files are very large and after the "image_path" keyword, they seem to contain strange strings.
Could it be that these files also contain the images as well?

@rgmyr
Copy link
Owner

rgmyr commented Jun 21, 2020

Good catch! I somehow failed to notice that.

We may refactor PolygonDataset to use that data instead of jpegs at some point, or release new data with that issue fixed, but for now I've just pushed 89d0406 which adds scripts/prune_imageData.py and some associated notes in the docs/README.

@LukasMosser
Copy link
Author

I think keeping images as jpegs and the labels as jsons would make it easier to version the dataset. Simple diffs on the jsons are possible and makes it overall more lightweight.

@rgmyr
Copy link
Owner

rgmyr commented Jun 21, 2020

Yeah actually I agree, and I don't think the ability to browse the images in a plain old image viewer is something we'd want to get rid of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants