Skip to content

Commit

Permalink
fix some typos in last PR
Browse files Browse the repository at this point in the history
  • Loading branch information
revolunet committed Mar 26, 2015
1 parent d29ffa5 commit f216bdc
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 13 deletions.
16 changes: 7 additions & 9 deletions src/angular-google-analytics.js
Original file line number Diff line number Diff line change
Expand Up @@ -768,18 +768,16 @@ angular.module('angular-google-analytics', [])
} else {
this._createScriptTag();
}

};

}

// activates page tracking
if (trackRoutes) {
$rootScope.$on(pageEvent, function () {
me._trackPage();
});
};
/**
}

/**
* Track User Timings
* @timingCategory (Required): A string for categorizing all user timing variables into logical groups(e.g jQuery).
* @timingVar (Required): A string to identify the variable being recorded(e.g. JavaScript Load).
Expand All @@ -806,17 +804,17 @@ angular.module('angular-google-analytics', [])
},
createAnalyticsScriptTag: function (config) {
if (config) {
cookieConfig = config;
cookieConfig = config;
}

return me._createAnalyticsScriptTag();
},
createScriptTag: function (config) {
if (config) {
cookieConfig = config;
cookieConfig = config;
}

return me._createScriptTag();
return me._createScriptTag();
},
ecommerceEnabled: function () {
return me._ecommerceEnabled();
Expand Down
8 changes: 4 additions & 4 deletions test/unit/angular-google-analytics.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

'use strict';

describe('angular-google-analytics', function () {
describe('angular-google-analytics', function() {
beforeEach(module('angular-google-analytics'));
beforeEach(module(function (AnalyticsProvider) {
AnalyticsProvider.setAccount('UA-XXXXXX-xx');
Expand Down Expand Up @@ -580,7 +580,7 @@ describe('angular-google-analytics', function () {
describe('supports arbitrary page events', function () {
beforeEach(module(function (AnalyticsProvider) {
AnalyticsProvider.setPageEvent('$stateChangeSuccess');
}));e
}));

it('should inject the Analytics script', function () {
inject(function (Analytics, $rootScope) {
Expand Down Expand Up @@ -785,6 +785,8 @@ describe('angular-google-analytics', function () {
expect(document.querySelectorAll("script[src='http://www.google-analytics.com/ga.js']").length).toBe(scriptCount + 1);
});
});
});


describe('should add user timing', function () {
beforeEach(module(function (AnalyticsProvider) {
Expand All @@ -800,8 +802,6 @@ describe('angular-google-analytics', function () {
});
});
});



describe('directives', function () {
describe('gaTrackEvent', function () {
Expand Down

0 comments on commit f216bdc

Please sign in to comment.