Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs unclear about cursor.toArray() behavior with large datasets #1224

Open
benjaminsteward opened this issue May 24, 2018 · 1 comment
Open

Comments

@benjaminsteward
Copy link

This line in the description is a little misleading: 'Retrieve all results and pass them as an array to the given callback.'

https://rethinkdb.com/api/javascript/to_array/

I offer this up, because in the case of large datasets (it happened for me at 650+ rows), the callback will be called multiple times, until the data is finished processing. Perhaps the docs can reflect this nuance by adding the following line:

"In the case of large datasets, .toArray() callback may potentially be called multiple times as data is received from the cursor, which may cause errors."

@srh
Copy link
Contributor

srh commented May 25, 2018

I'm pretty sure you're describing a bug. Are you positive you're seeing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants