Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: GraphQL CMP Support #448

Open
1 task done
gorillamoe opened this issue Sep 6, 2024 · 3 comments · May be fixed by #452
Open
1 task done

Feature: GraphQL CMP Support #448

gorillamoe opened this issue Sep 6, 2024 · 3 comments · May be fixed by #452
Labels
enhancement New feature or request

Comments

@gorillamoe
Copy link

gorillamoe commented Sep 6, 2024

Issues

  • I have checked existing issues and there are no existing ones with the same request.

Feature description

Hey there,

I checked the last releases and was happy to see you have GQL support, now.

Maybe you can implement something similiar to this: https://github.com/mistweaverco/kulala.nvim/blob/813a1d20cb8eb975c073c04c0761a59420d52bd8/lua/kulala/graphql/init.lua?plain=1#L10

Where you offer a public function for downloading a gql schema.

Then your users could also use this https://github.com/mistweaverco/kulala-cmp-graphql.nvim

It basically offers the users auto-complete on the GraphQL Query/Mutation

Which might be really awesome, if we have a collab on this 👍

@gorillamoe gorillamoe added the enhancement New feature or request label Sep 6, 2024
@boltlessengineer
Copy link
Contributor

boltlessengineer commented Sep 6, 2024

Thank you so much for pointing out the code reference. I wanted to support existing kulala-cmp-graphql.nvim but have no idea how to deal with gql schemas.
This will be really helpful. I’ll take a look about how gql schema works this weekend.

@gorillamoe
Copy link
Author

gorillamoe commented Sep 10, 2024

Hey @boltlessengineer and @NTBBloodbath do you guys mind if I just open an ugly PR that implements this basic functinoality and you can just rework that, so it fits your coding standards?

It might be easier for both of you to just edit already working code.

Quick sidenote: rest.nvim is already mentioned in the https://github.com/mistweaverco/kulala-cmp-graphql.nvim README, so people know that it's not tied to a specific tool and they are free to use whatever works best for them.

@boltlessengineer
Copy link
Contributor

@gorillamoe That would be even more helpful! It is always better to let people who knows the feature more to implement what they want. :)

@gorillamoe gorillamoe linked a pull request Sep 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants