Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out how to safely test code from PRs? #18

Open
olsonadr opened this issue May 25, 2022 · 0 comments
Open

Figure out how to safely test code from PRs? #18

olsonadr opened this issue May 25, 2022 · 0 comments

Comments

@olsonadr
Copy link
Collaborator

It seems like it would be nice to not have to merge potentially failing code just to check if it passes tests or not.

As far as I can tell so far, you need to have valid credentials in order cdk synth, which is required for sam local testing, but it's entirely possible I'm wrong here. It does seem like it should only require an account_id as opposed to the full access keys for deployment, but it would obviously be safer not to expose anything.

I'm hopeful we could find possible solutions on the CDK side, or by having a dedicated branch for testing PRs, etc. I'm not sure what the best approach here might be. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant