Notifications workflow error: Email body empty on submission promoted notification

[kepae]

Per recent staging deploy workflow:
https://github.com/responsible-ai-collaborative/aiid/actions/runs/12378897056/job/34555123176?pr=3281

Run npm run process-notifications:ci

> [email protected] process-notifications:ci
> node -r ts-node/register src/scripts/process-notifications.ts

New Incidents: No pending notifications to process.
New Entity Incidents: No pending notifications to process.
New Updated Incidents: No pending notifications to process.
{
  headers: {
    'cache-control': 'no-cache, private',
    'cf-cache-status': 'DYNAMIC',
    'cf-ray': '8f394996a958cb85-LAX',
    connection: 'close',
    'content-type': 'application/json',
    date: 'Tue, 17 Dec 2024 19:23:25 GMT',
    server: 'cloudflare',
    'strict-transport-security': 'max-age=31536000; includeSubDomains',
    'transfer-encoding': 'chunked',
    'x-apiquota-remaining': '99985',
    'x-apiquota-reset': '2024-12-18T00:00:00Z',
    'x-ratelimit-limit': '15',
    'x-ratelimit-remaining': '14'
  },
  body: {
    message: 'The email objects are required. #MS42230',
    errors: { data: [Array] }
  },
  statusCode: 422,
  message: '[Process Pending Notifications: Submission Promoted]: [Send Email]: undefined'
}

Error reported from this logic:

aiid/site/gatsby-site/src/scripts/process-notifications.ts

Line 397 in cce74c7

error.message = `[Process Pending Notifications: Submission Promoted]: ${error.message}`;

The thrown error message is undefined, but the inner JSON of the error indicates the email body wasn't set in sendEmail. Maybe something to do with locating the template? But there's a check for that...

  body: {
    message: 'The email objects are required. #MS42230',
    errors: { data: [Array] }
  }

Code	Name	Explanation
MS42230	The email objects are required.	The request payload provided does not contain any email object. Please check the payload and contact Customer Support for more help.

[cesarvarela]

@kepae
I left a comment in the staging pr. This happened because Danny's user is not in the staging database.

We should not account for this in the code because it will only happen if you restore a partial database as we do from production to staging.

[kepae]

Makes sense to me. Then perhaps the right behavior is at least: this error message is more detailed. But, that makes plenty of sense. We can clear the notifications from staging or restore after there are no such notifications pending.

[cesarvarela]

I added a check just in case because we'll deal with this occasionally when restoring from production, such as if a user gets deleted for testing purposes or someone requests it, etc.