Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPEC-ACTIONS - UVQUAN as action value #173

Open
tjobes opened this issue Jul 25, 2024 · 3 comments
Open

SPEC-ACTIONS - UVQUAN as action value #173

tjobes opened this issue Jul 25, 2024 · 3 comments

Comments

@tjobes
Copy link

tjobes commented Jul 25, 2024

In the SPEC-ACTIONS block, this set of lines cannot be successfully imported from a UCI into the HDF5 file:

UVQUAN lkstag RCHRES 1 STAGE
UVQUAN lkarea RCHRES 1 SAREA
UVQUAN hdiff GLOBAL WORKSP 10

UVNAME HDIFF 1 WORKSP 10 1.0 QUAN

*** Compute head difference
GENER 1 HDIFF = lkstag
GENER 1 HDIFF -= gwstag

The error is not recognizing that "lkstag" and "gwstag" needs to be translated from text into a value in the action lines at the end - it only tries to read it as a number, and dies. The code should take the action quantity field and identify whether it is text or number, and if the former, it should look for it in the UVQUAN list.

See the "GTQUAN" calls in SPACT (and SPBKCK for IF statements using UVQUANs to set logical conditions).

@PaulDudaRESPEC
Copy link
Member

Hey @tjobes , pleased to see you're looking at the project!

Special Actions isn't all that far along yet. -- we've got the basic 'Action' lines working for limited cases in HYDR and SEDTRN, but there's much more to be done. @rburghol contributed some great stuff for using python code to do more complex actions, but at this point we haven't provided a simple way to get more complex special actions into that format.

It's good to have this noted in the issues list... and if you want to contribute, we'll be happy to break off a piece for you to work on!

@rburghol
Copy link
Contributor

@tjobes - just to add to what @PaulDudaRESPEC noted, I am currently putting in some work on UVQUAN and UVNAME, and would be delighted to get your help testing that out if you are interested. I will post in this issue when I make some new commits.

@rburghol
Copy link
Contributor

@tjobes - do you have a UCI and WDM setup you can share for this example? I'd like to do some code testing on UVQUAN over the next few days and this will be ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants