Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finds new something in nowdocs/heredocs #1

Open
beberlei opened this issue Aug 17, 2013 · 4 comments
Open

Finds new something in nowdocs/heredocs #1

beberlei opened this issue Aug 17, 2013 · 4 comments

Comments

@beberlei
Copy link

When i run the tool on files with nowdocs/heredocs containing the words new foo then it things foo is a classname that is undefined.

@bashofmann
Copy link
Contributor

That reminds me again that I always wanted to migrate the tool to use php_parser instead of doing everything by hand with regexes. Shouldn't be too hard and also would catch all of these cases that don't happen in our codebase like this one. Unfortunately I don't know when I'll have time for it, especially since it's no pressing issue for us at the moment as the tool does what it is supposed to do very well on our codebase ;)

@Rican7
Copy link

Rican7 commented Feb 13, 2015

Is this still valid? It looks like you're using PHPParser now.

@Rican7
Copy link

Rican7 commented Feb 13, 2015

Ah... I just noticed you're including the PHPParser in composer but it doesn't look like any of the code is actually using it. :/

@bashofmann
Copy link
Contributor

Unfortunately I did not get any further then this so far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants