Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help in dedicated views is not based on flask-wiki package #984

Open
PascalRepond opened this issue Jun 3, 2024 · 0 comments
Open

Help in dedicated views is not based on flask-wiki package #984

PascalRepond opened this issue Jun 3, 2024 · 0 comments
Labels
bug Breaks something but is not blocking f: dedicated Adaptation of the views for dedicated clients

Comments

@PascalRepond
Copy link
Contributor

Bug description:

Search and some othe functionnalities of the SONAR help do not work when in a dedicated view.

The fixing of the following issue (#709) was poorly implemented with code from the flask-wiki package being copy-pasted directly into SONAR (see https://github.com/rero/sonar/tree/staging/sonar/help). When upgrading flask-wiki, the code in SONAR becomes deprecated and breaks.

Expected behavior:

  • The integration of flask-wiki in SONAR should only use the flask-wiki package.
  • Accessing the help from a dedicated view should not bring us back to the main SONAR URL but should stay in the dedicated interface.

Steps to Reproduce:

  1. Go to FOLIA
  2. Click on "Help/documentation"
  3. Try to search inside of the help module
  4. See error https://folia.unifr.ch/unifr/help/search?q=ad
  • Versions: v1.10.1
@PascalRepond PascalRepond added the bug Breaks something but is not blocking label Jun 3, 2024
@PascalRepond PascalRepond added f: dedicated Adaptation of the views for dedicated clients production Issue specifically spotted on the production server and removed production Issue specifically spotted on the production server labels Jun 3, 2024
@PascalRepond PascalRepond moved this from Inbox to Product Backlog in SONAR issues Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Breaks something but is not blocking f: dedicated Adaptation of the views for dedicated clients
Projects
Status: Product Backlog
Development

No branches or pull requests

1 participant