Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ebooks that do not exist in the provider are not correctly deleted/updated in ILS #3718

Open
PascalRepond opened this issue Jul 11, 2024 · 1 comment · May be fixed by #3802
Open

Ebooks that do not exist in the provider are not correctly deleted/updated in ILS #3718

PascalRepond opened this issue Jul 11, 2024 · 1 comment · May be fixed by #3802
Assignees
@rerowep
Labels
bug Breaks something but is not blocking client request Issue reported by production libraries f: ebooks

Comments

@PascalRepond
Copy link
Contributor

Bug description:

Ebooks from Cantook providers are loaded through rero/rero-ebooks through OAI/PMH. When an ebook is no more available in the provider, it should also be deleted from the catalog.

Expected behavior:

The ebooks task checks:

  • All existing dynamically loaded ebook documents that do not exist in OAI at all are deleted (holdings + document) from ILS
    • careful with the filter: some ebooks and some document harvested:true are not treated this way
  • All existing ebooks that do not exit anymore in OAI for ebibliomedia but that still exist in VS-Cantook are deleted only from the corresponding view (delete only holdings from the view)

Steps to Reproduce:

  1. Go to https://bib.rero.ch/professional/records/documents/detail/2059137
  2. Click on a link in the holdings
  3. See that this ebook is not available for this institution and should be deleted from ILS
@PascalRepond PascalRepond added the bug Breaks something but is not blocking label Jul 11, 2024
@PascalRepond PascalRepond added f: ebooks client request Issue reported by production libraries labels Jul 11, 2024
@PascalRepond PascalRepond moved this from Inbox to Product Backlog in RERO ILS issues Jul 16, 2024
@rerowep
Copy link
Contributor

rerowep commented Nov 6, 2024

External script:

poetry run /network/nfs/data_ils/ils/scripts/ebooks.py reroils utils delete-old-ebooks -l /network/nfs/data_ils/ils/scripts/ebooks.log -v -c

rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 12, 2024
@rerowep
apiharvester: cantook harvesting
7b8ef73 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes rero#3718.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 12, 2024
@rerowep
apiharvester: cantook harvesting
773199b 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes rero#3718.

Co-Authored-by: Peter Weber <[email protected]>
@rerowep rerowep linked a pull request Dec 12, 2024 that will close this issue
Open
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 12, 2024
@rerowep
apiharvester: cantook harvesting
639e7f0 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes rero#3718.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 12, 2024
@rerowep
apiharvester: cantook harvesting
5f2af99 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes rero#3718.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 12, 2024
@rerowep
apiharvester: cantook harvesting
18901d0 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes rero#3718.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 12, 2024
@rerowep
apiharvester: cantook harvesting
51f4c6d 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes rero#3718.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 12, 2024
@rerowep
apiharvester: cantook harvesting
ddeb471 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes rero#3718.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 12, 2024
@rerowep
apiharvester: cantook harvesting
3d2ce54 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes rero#3718.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 12, 2024
@rerowep
apiharvester: cantook harvesting
4c39e80 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes rero#3718.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 12, 2024
@rerowep
apiharvester: cantook harvesting
7ae7d5b 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes rero#3718.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 12, 2024
@rerowep
apiharvester: cantook harvesting
55bbb28 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes rero#3718.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 12, 2024
@rerowep
apiharvester: cantook harvesting
ffaf490 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes rero#3718.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 13, 2024
@rerowep
apiharvester: cantook harvesting
5c01034 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes rero#3718.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 16, 2024
@rerowep
apiharvester: cantook harvesting
e91eeb2 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes rero#3718.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 16, 2024
@rerowep
apiharvester: cantook harvesting
f02f579 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes rero#3718.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 16, 2024
@rerowep
apiharvester: cantook harvesting
9379779 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes rero#3718.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 16, 2024
@rerowep
apiharvester: cantook harvesting
719b00a 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes rero#3718.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 16, 2024
@rerowep
apiharvester: cantook harvesting
8ae111d 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes rero#3718.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 16, 2024
@rerowep
apiharvester: cantook harvesting
f951d56 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes rero#3718.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 16, 2024
@rerowep
apiharvester: cantook harvesting
5cce8d2 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes rero#3718.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 17, 2024
@rerowep
apiharvester: cantook harvesting
c39a772 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes rero#3718.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 17, 2024
@rerowep
apiharvester: cantook harvesting
105ccba 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes rero#3718.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 17, 2024
@rerowep
apiharvester: cantook harvesting
787a987 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes rero#3718.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 17, 2024
@rerowep
apiharvester: cantook harvesting
9adcee2 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes rero#3718.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 17, 2024
@rerowep
apiharvester: cantook harvesting
406f80e 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes rero#3718.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 17, 2024
@rerowep
apiharvester: cantook harvesting
5aa3757 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes rero#3718.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 17, 2024
@rerowep
apiharvester: cantook harvesting
630044d 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes rero#3718.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 17, 2024
@rerowep
apiharvester: cantook harvesting
70a1ff0 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes rero#3718.

Co-Authored-by: Peter Weber <[email protected]>
jma pushed a commit that referenced this issue Dec 18, 2024
@rerowep @jma
apiharvester: cantook harvesting
cef7b42 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes #3718.

Co-Authored-by: Peter Weber <[email protected]>
rerowep added a commit to rerowep/rero-ils that referenced this issue Dec 19, 2024
@rerowep
apiharvester: cantook harvesting
cd22f4b 
* Adds VS and NJ CANTOOK API harvesting.
* Deletes OAI ebooks harvesting.
* Closes rero#3718.

Co-Authored-by: Peter Weber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rerowep rerowep

Labels
bug Breaks something but is not blocking client request Issue reported by production libraries f: ebooks
Projects
RERO ILS issues
Status: In Development
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

apiharvester: cantook harvesting rerowep/rero-ils
2 participants
@rerowep @PascalRepond