Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have removeCombined remove templates as well as JS #654

Closed
MartinLogan opened this issue Mar 21, 2014 · 2 comments
Closed

Have removeCombined remove templates as well as JS #654

MartinLogan opened this issue Mar 21, 2014 · 2 comments

Comments

@MartinLogan
Copy link

It appears from running an r.js build with removeCombined that the text! prefixed defines do not get removed from the build directory.

I'm scanning through thr code to see if I can create a pull request for this, but wanted to check whether it is intentionally like that or not.

@jrburke
Copy link
Member

jrburke commented Mar 21, 2014

Yes, definitely a weakness right now: the issue is that loading via plugins is opaque to the loader, the loader does not know what files are involved with a plugin load, but I do want to allow plugins to opt in to the remove behavior. I am tracking this as #344, so will close this bug in favor of tracking any discussion or changes in that bug.

@jrburke jrburke closed this as completed Mar 21, 2014
@MartinLogan
Copy link
Author

Thanks - I'll follow the discussion - the separation seems correct and it sounds like the correct way to go is to make the plugin responsible for communicating that the resource is disk based and can be cleaned up.

Really enjoying working with r.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants