From 2e55aa68bb06ae7713b8b634df0eb91ca688e337 Mon Sep 17 00:00:00 2001 From: Salah Aldeen Al Saleh Date: Wed, 18 Dec 2024 17:06:35 -0800 Subject: [PATCH] add comments --- pkg/plan/embeddedcluster.go | 1 + pkg/plan/plan.go | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/pkg/plan/embeddedcluster.go b/pkg/plan/embeddedcluster.go index d52e96342e..bd3b9bdee7 100644 --- a/pkg/plan/embeddedcluster.go +++ b/pkg/plan/embeddedcluster.go @@ -52,6 +52,7 @@ func executeECUpgrade(s store.Store, p *types.Plan, step *types.PlanStep) error return errors.Wrap(err, "failed to load kotskinds from path") } + // TODO (@salah): old kots should not be constructing the new installation object newInstall := &ecv1beta1.Installation{ TypeMeta: metav1.TypeMeta{ APIVersion: ecv1beta1.GroupVersion.String(), diff --git a/pkg/plan/plan.go b/pkg/plan/plan.go index 2637c0c7b6..8f41a8a8fe 100644 --- a/pkg/plan/plan.go +++ b/pkg/plan/plan.go @@ -53,6 +53,10 @@ func PlanUpgrade(s store.Store, opts PlanUpgradeOptions) (*types.Plan, error) { Owner: types.StepOwnerKOTS, }) + // TODO (@salah): add a step to upgrade kots here + // to make sure later steps are executed by the new version, + // as old kots might not be able to parse new kots kinds (and EC config) + // embedded cluster upgrade if ecVersion != util.EmbeddedClusterVersion() { plan.Steps = append(plan.Steps, &types.PlanStep{