Support Replay RDT fork #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bvaughn
force-pushed
the
feature/replay-react-devtools-ui-fork
branch
from
88344ba
to
f75f13d
Compare
bvaughn
force-pushed
the
feature/replay-react-devtools-ui-fork
branch
from
f75f13d
to
65934b0
Compare
bvaughn
force-pushed
the
feature/replay-react-devtools-ui-fork
branch
from
65934b0
to
9b807f1
Compare
|
I'm going to just merge this. |
|
Yep, sorry, that's good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pairs with replayio/devtools#9807
Testing
I'm running Node v18 and the
build:chromestep failed for me with anERR_OSSL_EVP_UNSUPPORTEDerror. The work around was to use the--openssl-legacy-providerflag.Then I had to copy the contents of
<react-root>/packages/react-devtools-extension/chrome/build/unpacked/build/react_devtools_backend_compact.jsinto the function in
<replay-root>/src/ui/components/SecondaryToolbox/react-devtools/react_devtools_backend.raw.js