Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export RDT Store #13

Closed
wants to merge 3 commits into from
Closed

Export RDT Store #13

wants to merge 3 commits into from

Conversation

Mokshit06
Copy link

@Mokshit06 Mokshit06 commented Nov 9, 2023 •
edited
Loading

Draft PR for visibility. Exports RDT Store class from @replayio/react-devtools-inline through a replay entrypoint

@Mokshit06 Mokshit06 marked this pull request as draft November 9, 2023 21:29
bvaughn
bvaughn reviewed Dec 5, 2023
View reviewed changes
packages/react-devtools-inline/src/replay.js Outdated
@@ -0,0 +1,3 @@
/** @flow */

export {default as Store} from 'react-devtools-shared/src/devtools/store';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's stick with named exports for this file. We may want to add other things?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Pushed the changes.

bvaughn
bvaughn approved these changes Dec 5, 2023
View reviewed changes
Copy link

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to export printStore or is the description outdated?

This looks fine. We should land it, then update your other PR.

@Mokshit06 Mokshit06 changed the title Export Store and printStore Export RDT Store Dec 5, 2023
@Mokshit06
Copy link
Author

The title and description were outdated. We don't need to export printStore because we don't want the display name of components in serialised tree as done here. I have updated them as well.

@bvaughn
Copy link

bvaughn commented Dec 5, 2023

Okay. I think this looks fine then.

Need someone (@markerikson ) to publish to NPM as I don't have permissions

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@markerikson markerikson closed this Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvaughn bvaughn bvaughn approved these changes

Assignees
No one assigned
Labels
Resolution: Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mokshit06 @bvaughn @markerikson