Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perhaps consider using SIMD? #11

Open
antonmarsden opened this issue Apr 18, 2020 · 3 comments
Open

Perhaps consider using SIMD? #11

antonmarsden opened this issue Apr 18, 2020 · 3 comments

Comments

@antonmarsden
Copy link

antonmarsden commented Apr 18, 2020

Just a thought :)
https://software.intel.com/en-us/articles/fast-computation-of-adler32-checksums

It appears that there's already an SIMD implementation on this fork: https://github.com/myfreeweb/adler32-simd-rs

@antonmarsden antonmarsden changed the title Perhaps consider hardware acceleration? Perhaps consider using SIMD? Apr 18, 2020
@remram44
Copy link
Owner

remram44 commented Apr 19, 2020

I'm taking his benchmark d28c892 😉

I don't know if SIMD is crucial, since I'm seeing speeds well over 1GB/s without, but if there is interest and the implementation is good why not.

@antonmarsden
Copy link
Author

You make a fair point. The current implementation is probably adequate for now, and improvements would only really benefit applications doing a lot of [de]compression (file/image processing).

@antonmarsden
Copy link
Author

I'm going to experiment with an implementation of this - looks like adler32 is still being used by miniz_oxide, which is a pure Rust [de]compressor, which is used by flate2. adler32 is also still used by the "older" compression libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants