-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] React Router v7 completely broke remix-hook-form #12401
Comments
Looks like the same issue as #12399, we're getting a patch out shortly Thanks for your patience @AlemTuzlak! |
Thank you Brooks 🫶 |
Fixed by #12437 and available in v7.0.2 Thanks for your patience Alem! I'm going to go ahead and close this issue |
@brookslybrand @AlemTuzlak I figured out, this is only fixed until node v22, in node v23 it is still causing the same issue :) |
@brookslybrand It is still broken for me even on on |
Re-opened in #12475 |
I'm using React Router as a...
framework
Reproduction
https://stackblitz.com/edit/github-k5nghg?file=app%2Froutes%2Fhome.tsx
System Info
Doesn't matter, repro above!
Used Package Manager
npm
Expected Behavior
It works
Actual Behavior
it dies.
After my investigation I figured out that it dies in
entry.server.ts
and if I wrap it into aClientOnly
component then it works. All I did to upgraderemix-hook-form
to support react-router v7 is change thepeerDependency
from@remix-run/react
toreact-router
and this used to work just fine before. I am not sure if something changed internally but I'd expect this to work, the source code that runs is here:https://github.com/forge42dev/remix-hook-form/blob/main/src/hook/index.tsx
You can see everything I use from react-router there. Thank you for the help!
The text was updated successfully, but these errors were encountered: