[Bug]: Too many v7 warnings

[ebnazmul]

What version of React Router are you using?

[email protected]

Steps to Reproduce

I tried

Expected Behavior

No warning

Actual Behavior

Too much warnings

[Eghizio]

@ebnazmul see #12245

[timdorr]

For the moment, the best course of action is to downgrade to 6.27.0 and lock your version to that release. The only things added in 6.28.0 are these warnings, so you're not missing any features or fixes by downgrading to that version.

[jbblanchet]

I know it's not explicit here, but it would be nice if explicitly opting out the flags (i.e. v7_skipActionErrorRevalidation: false) would stop the warning. It's my way of saying "I got the message, I created a ticket to follow up on this, please stop warning me."

[dd-jonas]

I don't see the reason for adding these warnings. This seems to belong in a changelog, not in the console. None of these feature flags have any impact on my application. Why should I enable them all explicitly, only to remove them again in v7?

[brookslybrand]

I don't see the reason for adding these warnings. This seems to belong in a changelog, not in the console. None of these feature flags have any impact on my application. Why should I enable them all explicitly, only to remove them again in v7?

You should enable them if you plan to upgrade to v7. Each of these flags opts you into behavior that you cannot opt out of in v7. Adopting each flag allows you to test, commit, and deploy 1 by 1. If you're happy with bumping from v6 to v7 without using the flags, then you can just do that. If you don't intend to go to v7 for whatever reason, just pin your version to 6.27.0 like @timdorr suggested.

step-by-step v6 upgrade guide

[jbblanchet]

@brookslybrand I'm sorry, but that's not a great solution. What if there's a security patch in 6 months? You don't get it because you pinned your version? Or you upgrade it manually and then get the warnings? I think the community has been providing feedback that's helpful and constructive, and dismissing it by telling us to pin our version is not the best path forward.

[brookslybrand]

Not trying to be dismissive, and I do appreciate your suggestion @jbblanchet. I went ahead and opened #12441, but I'll let @brophdawg11 decide whether or not it makes sense to allow users to opt out of flags.

Personally I don't think it's a good idea to opt out of a flag just to silence a legitimate warning, but if that's what the community wants, your solution at least makes it very explicit that's what you are doing.

[jbblanchet]

I appreciate it, thanks.