Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DSA/SHA1 (RFC 2536) #50

Open
gnarea opened this issue Nov 17, 2022 · 0 comments
Open

Add support for DSA/SHA1 (RFC 2536) #50

gnarea opened this issue Nov 17, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@gnarea
Copy link
Member

gnarea commented Nov 17, 2022

An error will be thrown during verification if DSA/SHA1 is used, as we're not currently implementing this algorithm because:

  1. It uses SHA-1 and DSA with 1024-bit keys, both of which are grossly insecure.
  2. No TLD uses this algorithm as of November 2022 (curl -s http://www.internic.net/domain/root.zone | awk '$4 == "DS" { print $6}' | sort -n | uniq -c).
  3. Given our current time constraints and the issues above, we can't justify implementing this feature now.

Having said this, we'd welcome a PR to add support for this algorithm as specified in RFC 2536.

@gnarea gnarea changed the title Implement (de)serialisation of DSA/SHA1 keys Add support for DSA/SHA1 Nov 17, 2022
@gnarea gnarea modified the milestone: Version 1 Nov 17, 2022
@gnarea gnarea changed the title Add support for DSA/SHA1 Add support for DSA/SHA1 (RFC 2536) Nov 18, 2022
gnarea added a commit that referenced this issue Nov 18, 2022
kodiakhq bot pushed a commit that referenced this issue Nov 18, 2022
@gnarea gnarea added automerge Allow kodiak to automerge commit when all checks pass enhancement New feature or request and removed automerge Allow kodiak to automerge commit when all checks pass labels Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant