Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Courier sync reported as failed even if successful #1107

Open
gnarea opened this issue Mar 16, 2022 · 1 comment
Open

Courier sync reported as failed even if successful #1107

gnarea opened this issue Mar 16, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@gnarea
Copy link
Member

gnarea commented Mar 16, 2022

The following is displayed at the end of every sync, even if the sync actually succeeded.

err

I narrowed down the issue to this line no longer having any effect, probably after upgrading the third-party lib ws:

The client is getting a 1005 code, which it doesn't expect:

if (closeEventCode !== 1000) {
throw new CourierSyncError(`Socket error: ${closeEventCode}`);
}

WireShark shows that the server is closing the connection without a close code, so it makes sense that the client gets a 1005.

@gnarea gnarea added the bug Something isn't working label Mar 16, 2022
@gnarea gnarea changed the title Courier sync reported as failure even if successful Courier sync reported as failed even if successful Mar 16, 2022
@gnarea
Copy link
Member Author

gnarea commented Mar 18, 2022

I should try to upgrade ws-mock first as that could shed some light: #1110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant