Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ending the transformed stream? #5

Open
andrewplummer opened this issue Jul 20, 2015 · 2 comments
Open

Ending the transformed stream? #5

andrewplummer opened this issue Jul 20, 2015 · 2 comments
Labels

Comments

@andrewplummer
Copy link

Apologies in advance as I really don't know what I'm doing when it comes to streams, but I noticed that using this lib in a gulp command the returned transform doesn't report as having ended. I added:

transform.emit('end');

on line 155 of index.js and it seemed to work? I have no idea if this makes sense or not though...

@rekow rekow added the bug label Jul 24, 2015
@rekow
Copy link
Owner

rekow commented Jul 24, 2015

Hey! Your fix definitely ensures the transform reports ending, thanks for opening the issue. Yeah the lib is just super out of date and a bit sloppy - something I hacked together and haven't gotten to clean up.

I'm currently rewriting to fix the underlying problem of proxying the streams via an unneeded passthrough, so hoping to have this issue closed by the end of the weekend.

@andrewplummer
Copy link
Author

Ok! Well it's served me very well so far.. thanks for working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants