Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make prodigy command respect display-buffer-alist #149

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

make prodigy command respect display-buffer-alist #149

wants to merge 2 commits into from

Conversation

lem102
Copy link

@lem102 lem102 commented Nov 28, 2024 •
edited
Loading

closes #146

DamienCassou
DamienCassou reviewed Dec 1, 2024
View reviewed changes
Copy link
Collaborator

@DamienCassou DamienCassou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. Can you please check the tests? They don't pass on the CI.

@lem102 lem102 force-pushed the prodigy-command-respect-display-buffer-alist branch from 29e2993 to 63d76e5 Compare December 3, 2024 20:06
@lem102
Copy link
Author

lem102 commented Dec 3, 2024

I'm struggling to run the tests locally. Are the docs for running the tests up to date? Running make doesn't seem to do anything related to running the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamienCassou DamienCassou DamienCassou left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot use major mode in display-buffer-alist to control prodigy-mode buffer placement
2 participants
@lem102 @DamienCassou