cannot use major mode in display-buffer-alist to control prodigy-mode buffer placement

[lem102]

Hello, thanks for this great package.

I have this code so that if a prodigy-mode buffer is displayed, it is displayed in the window currently in use.

(setopt display-buffer-alist '(((major-mode . prodigy-mode) (display-buffer-same-window))))

This works as expected when using the prodigy-mode command with a prodigy buffer already open, however with no prodigy buffer open this display buffer rule is not respected.

I think when we are creating a new prodigy buffer with the below command, we display the new buffer before setting the mode, so the above display buffer rule does not trigger.

(defun prodigy ()
  "Manage external services from within Emacs."
  (interactive)
  (let ((buffer-p (prodigy-buffer))
        (buffer (get-buffer-create prodigy-buffer-name)))
    (pop-to-buffer buffer) ; display-buffer is called here
    (unless buffer-p
      (prodigy-mode) ; the mode is set here
      )
    (prodigy-start-status-check-timer)))

I have this code to work around the issue:

(defun jacob-prodigy ()
  "Manage external services from within Emacs."
  (interactive)
  (with-current-buffer (get-buffer-create prodigy-buffer-name)
    (prodigy-mode)
    (prodigy-start-status-check-timer)
    (pop-to-buffer (current-buffer))))

(advice-add #'prodigy :override #'jacob-prodigy)

Am happy to open a PR to work on this.

[DamienCassou]

A PR would make sense in my opinion. Thank you!