Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve config modification and lint instructions #6

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Conversation

be32826
Copy link
Contributor

@be32826 be32826 commented Jan 10, 2024

  • Simplify delta loop in README
  • Add more comments in README
  • Add all targets as defaults
  • Lint config.mips64el

@be32826 be32826 requested a review from AndrewFasano January 10, 2024 20:30
@AndrewFasano
Copy link

Thanks, I like this. One thing I was seeing with armeb and mips64el - it doesn't seem like building for those targets actually does anything. Maybe I had something set up wrong on my machine? But that's why the mips64el config had some non-linted options and wasn't included in the default list.

@be32826
Copy link
Contributor Author

be32826 commented Jan 12, 2024

One thing I was seeing with armeb and mips64el - it doesn't seem like building for those targets actually does anything.

Apparently it's because the build fails because our kernel version is too old (or our gcc version is too new). This is the relevant upstream commit we're missing: torvalds/linux@bee2003.

@AndrewFasano
Copy link

Gotcha, so we should cherry-pick that commit over to our 4.10 kernel and then merge this?

@be32826
Copy link
Contributor Author

be32826 commented Jan 17, 2024

Gotcha, so we should cherry-pick that commit over to our 4.10 kernel and then merge this?

Yeah, that's a good plan.

- Simplify delta loop in README
- Add more comments in README
- Add all targets to build.sh TARGETLIST
- Lint config.mips64el
@be32826 be32826 merged commit 766e9f9 into main Jan 17, 2024
1 check passed
@be32826 be32826 deleted the fix-mod-lint branch January 17, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants