Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge common options #10

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Merge common options #10

merged 1 commit into from
Jan 19, 2024

Conversation

be32826
Copy link
Contributor

@be32826 be32826 commented Jan 19, 2024

Resolves #3

You can verify that the configs stay the same after this PR by running the following commands in bash

git clone --depth 1 \
    --branch merge-common-options \
    https://github.com/panda-re/linux_builder linux_builder_new

git clone --depth 1 \
    https://github.com/panda-re/linux_builder linux_builder_old

for target in armeb armel mipseb mipsel mips64eb mips64el; do
    old_config=$(cat linux_builder_old/config.$target | sort | sed '/^#/d')
    new_config=$(cpp -P -undef linux_builder_new/configs/$target | sort)

    echo -n "$target "
    if [ "$old_config" == "$new_config" ]; then
        echoelse
        echofi
done

For me, this outputs

armeb ✅
armel ✅
mipseb ✅
mipsel ✅
mips64eb ✅
mips64el ✅

@be32826 be32826 marked this pull request as draft January 19, 2024 00:18
@be32826 be32826 force-pushed the merge-common-options branch from 4f50e3a to 515782f Compare January 19, 2024 16:19
@be32826 be32826 force-pushed the merge-common-options branch from 515782f to 69e5c53 Compare January 19, 2024 16:57
@be32826 be32826 marked this pull request as ready for review January 19, 2024 17:00
@be32826 be32826 requested a review from AndrewFasano January 19, 2024 17:02
@AndrewFasano
Copy link

This is awesome

@AndrewFasano AndrewFasano merged commit 150bd70 into main Jan 19, 2024
1 check passed
@AndrewFasano AndrewFasano deleted the merge-common-options branch January 19, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "includes" in configs to reduce duplication
2 participants