Skip to content
This repository has been archived by the owner on May 19, 2024. It is now read-only.

[Help] Find new command-line arguments in Heroic #112

Open
redromnon opened this issue Nov 11, 2022 · 3 comments
Open

[Help] Find new command-line arguments in Heroic #112

redromnon opened this issue Nov 11, 2022 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@redromnon
Copy link
Owner

Description:
As Heroic improves and matures over time, its complexity of handling game launching also increases.

Under the hood, Heroic runs a launch command with a set of arguments for running a game. This is precisely what Bash Launcher aims to do through bash scripts.

With every new release, new arguments may be added to the launch command. Some of these arguments are applied via options in the settings while others are included to avoid errors or to improve compatibility.

Solution:
You can contribute to this project is by

  • Identifying new launch arguments implemented in Heroic
  • Noting how and why they are included

If you find one, feel free to create a new Feature Request or Pull Request!

@redromnon redromnon pinned this issue Nov 11, 2022
@redromnon redromnon added the help wanted Extra attention is needed label Nov 11, 2022
@afwolfe
Copy link
Contributor

afwolfe commented Jan 2, 2023

I am interested in refactoring checkparameters.py to reduce maintenance on adding future options by using a dictionary and list(s) to store the environment variables and launch arguments while handling each configuration option. I have also identified a few options that seem to be deprecated in Heroic (audioFix and enableResizableBar). I will submit a PR when I have something polished.

@redromnon
Copy link
Owner Author

Sure, sounds good to me.

@redromnon
Copy link
Owner Author

Hey @afwolfe!
I'll take a look at those PRs and test them once I find the time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants