Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console 67 self service license trials and graceful license expiry merge #1541

Conversation

jvorcak
Copy link
Collaborator

@jvorcak jvorcak commented Nov 29, 2024

No description provided.

Copy link

github-actions bot commented Nov 29, 2024

The latest Buf updates on your PR. Results from workflow Buf CI / push-module (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedNov 29, 2024, 2:39 PM

@jvorcak jvorcak marked this pull request as ready for review November 29, 2024 14:29
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if it needs to generate a new openapi.json file

Comment on lines -79 to -88
{soonToExpireLicenses.length > 0 && (
<Button variant="outline" size="sm" as="a" target="_blank" href="https://redpanda.com/license-request">
Renew license
</Button>
)}
{showEnterpriseFeaturesWarning && (
<Button variant="outline" size="sm" as="a" target="_blank" href="https://www.redpanda.com/try-redpanda">
Request a trial
</Button>
)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to keep this or is it intentional to request license?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this was an explicit request on one of the last calls.

Copy link
Contributor

@malinskibeniamin malinskibeniamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor comments

@jvorcak jvorcak merged commit ea1a7eb into master Nov 29, 2024
8 checks passed
@jvorcak jvorcak deleted the CONSOLE-67-self-service-license-trials-and-graceful-license-expiry-merge branch November 29, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants