-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Console 67 self service license trials and graceful license expiry merge #1541
Console 67 self service license trials and graceful license expiry merge #1541
Conversation
…-license-trials-and-graceful-license-expiry
…-graceful-license-expiry-merge
The latest Buf updates on your PR. Results from workflow Buf CI / push-module (pull_request).
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if it needs to generate a new openapi.json
file
{soonToExpireLicenses.length > 0 && ( | ||
<Button variant="outline" size="sm" as="a" target="_blank" href="https://redpanda.com/license-request"> | ||
Renew license | ||
</Button> | ||
)} | ||
{showEnterpriseFeaturesWarning && ( | ||
<Button variant="outline" size="sm" as="a" target="_blank" href="https://www.redpanda.com/try-redpanda"> | ||
Request a trial | ||
</Button> | ||
)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to keep this or is it intentional to request license?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use https://redpanda.com/license-request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this was an explicit request on one of the last calls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some minor comments
No description provided.