proto: add debug_bundle_process_not_started property to GetDebugBundl… #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / push-module (pull_request).
|
bojand
force-pushed
the
backend/debug_bundle_not_started
branch
from
ab12283 to
488b623
Compare
weeco
reviewed
Nov 8, 2024
|
|
||
| // true IFF all broker statuses return | ||
| // "debug bundle process" not started error code | ||
| bool debug_bundle_process_not_started = 2; |
There was a problem hiding this comment.
NIT: I'm not a friend of negated bools. I'd prefer to call if debug_bundle_process_started instead. WDYT?
There was a problem hiding this comment.
Changed to has_debug_process.
…eStatusResponse proto: add debug_bundle_process_not_started property to GetDebugBundleStatusResponse
bojand
force-pushed
the
backend/debug_bundle_not_started
branch
from
d3da772 to
1091e20
Compare
weeco
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eStatusResponse.
This is convenience property so that the frontend knows whether the debug bundle process was not started.