New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracing #4

Open

9ary opened this issue Apr 17, 2024 · 0 comments

Labels

Member

9ary commented Apr 17, 2024

Following a suggestion by @bb010g, this would be a cleaner way to implement progress reporting.

my preference: i'd not pass around progress bars, but rather use opentelemetry/minitrace/tracing to instrument your whole crate, and then report progress on the CLI based on emissions from that local telemetry.

https://lib.rs/crates/tracing-indicatif exists if you want to look at some code for that option.

The current hooks are fine, but the need to pass objects around pollutes the entire code base, so it'd be neat to get rid of them.

9ary added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment