Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

major refact #3

Open
toutouastro opened this issue Jul 12, 2012 · 4 comments
Open

major refact #3

toutouastro opened this issue Jul 12, 2012 · 4 comments

Comments

@toutouastro
Copy link

I think we should refactor the functions that manipulate messages.we should put them in a class where msg is a field and all the functions are methods that will make the code more oop.
what do you think @rednaks @njaguard ?

@rednaks
Copy link
Owner

rednaks commented Jul 13, 2012

ok it's interessting, can you make it into another branch ? we can try this and then review the MakeAction function, to let the bot make the right decision, the actual function is not really optimized and it makes many bugs.

@toutouastro
Copy link
Author

so I add a branch in my fork and then what ?
to avoid bugs we can write tests.

@toutouastro
Copy link
Author

I'am thinking of refactoring functions that uses the socket and put them in a class.

@rednaks
Copy link
Owner

rednaks commented Jul 13, 2012

yep we should think about these tests good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants