Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] quads-web js assets referring to 404 images #553

Closed
sadsfae opened this issue Nov 19, 2024 · 1 comment
Closed

[BUG] quads-web js assets referring to 404 images #553

sadsfae opened this issue Nov 19, 2024 · 1 comment

Comments

@sadsfae
Copy link
Member

sadsfae commented Nov 19, 2024

We seem to be trying to load assets from the following non-existent sources:

$QUADSURL/DataTables-1.10.22/images/sort_both.png
$QUADSURL/DataTables-1.10.22/images/sort_asc.png
$QUADSURL/DataTables-1.10.22/images/sort_asc_disabled.png

This results in a slow initial loading time for quads-web and the /available rendering, you can see this error in the f12 developer console window:

Failed to load resource: the server responded with a status of 404 (NOT FOUND)
Failed to load resource: the server responded with a status of 404 (NOT FOUND)

Screenshot_2024-11-19_08-17-57

We either need to remove references for this or utilize a relative path for them once we copy them locally into the repository assets to be served:

https://cdn.datatables.net/1.10.22/images/sort_both.png
https://cdn.datatables.net/1.10.22/images/sort_asc.png
https://cdn.datatables.net/1.10.22/images/sort_asc_disabled.png

From what I can see datatables is MIT-licensed and has no restrictions including in the repository:

https://memgraph.com/blog/what-is-mit-license#:~:text=Yes%2C%20the%20MIT%20License%20is,other%20licenses%2C%20including%20the%20GPL.

@sadsfae
Copy link
Member Author

sadsfae commented Nov 19, 2024

Perhaps related somewhat: f8f7cd6 I think we want to still serve these two files locally and only rely on external / third party files when absolutely necessary which in the case of the relatively simple design of /available rendering isn't needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants