Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding trailing backslash rule #899

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aireilly
Copy link
Member

Trailing backslashes in codeblocks break the openshift-docs Asciibinder build.

@aireilly
Copy link
Member Author

Fixes #857

Copy link

github-actions bot commented Oct 29, 2024

🎊 Navigate the preview: https://redhat-documentation-vale-at-red-hat-899.surge.sh 🎊

@aireilly aireilly requested a review from apinnick October 29, 2024 15:47
.Example
[source,terminal]
----
$ az role assignment create --role "<privileged_role>" \// <1>
Copy link
Collaborator

@apinnick apinnick Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a "normal" backslash without a callout to the testvalid file?

$ az role assignment \
  create --role "<privileged_role>"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will trigger the rule. I'll see if I can refine the regex to cater for this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into a similar issue when I tried to create a Vale rule that would flag lines in code that were missing backslashes. :-( Never did find a good solution.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could handle it with a script rule for sure.

@aireilly aireilly force-pushed the trailing-backslash branch 2 times, most recently from d295423 to 792bc2a Compare November 6, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants