-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
592: checking for correct assembly metadata - WIP #662
Open
rohennes
wants to merge
1
commit into
redhat-documentation:main
Choose a base branch
from
rohennes:592-assembly-metadata
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
5 changes: 5 additions & 0 deletions
5
.vale/fixtures/OpenShiftAsciiDoc/AssemblyContainsRequiredMetadata/.vale.ini
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
; Vale configuration file to test the `AssemblyContainsRequiredMetadata` rule | ||
StylesPath = ../../../styles | ||
MinAlertLevel = suggestion | ||
[*.adoc] | ||
OpenShiftAsciiDoc.AssemblyContainsRequiredMetadata = YES |
4 changes: 4 additions & 0 deletions
4
.vale/fixtures/OpenShiftAsciiDoc/AssemblyContainsRequiredMetadata/testinvalid.adoc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
//vale-fixture | ||
:context: <unique-context-for-assembly> | ||
= title | ||
|
8 changes: 8 additions & 0 deletions
8
.vale/fixtures/OpenShiftAsciiDoc/AssemblyContainsRequiredMetadata/testvalid.adoc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
//vale-fixture | ||
:_content-type: ASSEMBLY | ||
[id="<unique-heading-for-assembly>"] | ||
= Assembly title | ||
include::_attributes/input-attributes-file | ||
:context: some-context | ||
|
||
toc::[] |
37 changes: 37 additions & 0 deletions
37
.vale/styles/OpenShiftAsciiDoc/AssemblyContainsRequiredMetadata.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
--- | ||
extends: script | ||
message: "Assembly is missing required metadata. Ensure you include metadata for attributes, TOC and context." | ||
level: error | ||
link: https://github.com/openshift/openshift-docs/blob/main/contributing_to_docs/doc_guidelines.adoc#assembly-file-metadata | ||
scope: raw | ||
script: | | ||
text := import("text") | ||
matches := [] | ||
|
||
//trim extra whitespace | ||
scope = text.trim_space(scope) | ||
//add a newline, it might be missing | ||
scope += "\n" | ||
|
||
attribute_regex := "include::_attributes/" | ||
toc_regex := "toc::\\[\\]" | ||
context_regex := ":context:" | ||
matchAttribute := false | ||
matchToc := false | ||
matchContext := false | ||
|
||
//Check if context declaration is on any line | ||
for line in text.split(scope, "\n") { | ||
if text.re_match(attribute_regex, line){ | ||
matchAttribute = true | ||
} else if text.re_match(toc_regex, line){ | ||
matchToc = true | ||
} else if text.re_match(context_regex, line){ | ||
matchContext = true | ||
} | ||
} | ||
|
||
//Highlight first line if context declaration not found in file | ||
if !matchAttribute || !matchToc || !matchContext { | ||
matches = append(matches, {begin: 1, end: 10}) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,46 @@ | ||
/* | ||
Tengo Language | ||
Checks that lines are not hard-wrapped. | ||
$ tengo HardWrappedLines.tengo <asciidoc_file_to_validate> | ||
*/ | ||
|
||
fmt := import("fmt") | ||
os := import("os") | ||
text := import("text") | ||
|
||
input := os.args() | ||
scope := os.read_file(input[2]) | ||
matches := [] | ||
|
||
//trim extra whitespace | ||
scope = text.trim_space(scope) | ||
//add a newline, it might be missing | ||
scope += "\n" | ||
|
||
attribute_regex := "include::_attributes/" | ||
toc_regex := "toc::\\[\\]" | ||
context_regex := ":context:" | ||
matchAttribute := false | ||
matchToc := false | ||
matchContext := false | ||
|
||
//Check if context declaration is on any line | ||
for line in text.split(scope, "\n") { | ||
if text.re_match(attribute_regex, line){ | ||
matchAttribute = true | ||
fmt.println("Found attribute declaration.") | ||
} else if text.re_match(toc_regex, line){ | ||
matchToc = true | ||
fmt.println("Found toc declaration") | ||
} else if text.re_match(context_regex, line){ | ||
matchContext = true | ||
fmt.println("Found context declaration") | ||
} | ||
} | ||
|
||
//Highlight first line if context declaration not found in file | ||
if !matchAttribute || !matchToc || !matchContext { | ||
matches = append(matches, {begin: 1, end: 10}) | ||
fmt.println("Did not find correct metadata") | ||
fmt.println(matches) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.