Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs in ResourceHandle preference #117

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Fix bugs in ResourceHandle preference #117

merged 2 commits into from
Sep 4, 2024

Conversation

jkupferer
Copy link
Collaborator

@jkupferer jkupferer commented Sep 4, 2024 •
edited
Loading

  • Unready handles were preferred over ready handles
  • Unknown handle health was preferred over healthy
  • Older handles should be preferred, recent change flipped the logic

@jkupferer
Fix bug in ResourceHandle age preference
e835da5 
- Older handles should be preferred, recent change flipped the logic
@jkupferer
Fix resource handle preference logic.
c64f4ed
@jkupferer jkupferer changed the title Fix bug in ResourceHandle age preference Fix bugs in ResourceHandle preference Sep 4, 2024
makirill
makirill approved these changes Sep 4, 2024
View reviewed changes
Copy link

@makirill makirill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkupferer jkupferer merged commit f613661 into main Sep 4, 2024
1 check passed
@jkupferer jkupferer deleted the fix-resource-pool-age-preference branch September 4, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makirill makirill makirill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkupferer @makirill