Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for building ova images #435

Closed
wants to merge 1 commit into from
Closed

Add support for building ova images #435

wants to merge 1 commit into from

Conversation

nbeernink
Copy link

Description

This commit adds support for building ova images, which seemed to work just fine for me.

FIXES: #434

Type of change

What is it?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Tests update
  • Refactor

Checklist

  • Added changelog fragment (not sure how this works, I just made up my own number :)
  • Tests exist for affected features covering positive and negative scenarios

@mergify mergify bot added enhancement New feature or request test update new tests or updating existing ones labels Nov 10, 2024
maxamillion
maxamillion approved these changes Nov 10, 2024
View reviewed changes
Copy link
Collaborator

@maxamillion maxamillion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mergify mergify bot added the waiting for review Pull request is ready for review label Nov 11, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 12, 2024

This Pull Request needs all checks to run successfully. Could you fix it @nbeernink? 🙏

@mergify mergify bot added the invalid This doesn't seem right (PR check failure?) label Nov 12, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 13, 2024

This Pull Request needs all checks to run successfully. Could you fix it @nbeernink? 🙏

@nbeernink
Copy link
Author

LGTM 👍

Thanks @maxamillion anything else before this can be merged? Don't think I can fix the tests, I just copied what was already there.

@mergify mergify bot closed this Nov 26, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 26, 2024

This Pull Request looks stale. Feel free to reopen it if you think it's a mistake.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 27, 2024

This Pull Request needs all checks to run successfully. Could you fix it @nbeernink? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxamillion maxamillion maxamillion approved these changes

@thom-at-redhat thom-at-redhat Awaiting requested review from thom-at-redhat thom-at-redhat is a code owner

@de1987 de1987 Awaiting requested review from de1987 de1987 is a code owner

@resoluteCoder resoluteCoder Awaiting requested review from resoluteCoder resoluteCoder is a code owner

@matoval matoval Awaiting requested review from matoval matoval is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request invalid This doesn't seem right (PR check failure?) test update new tests or updating existing ones waiting for review Pull request is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

builder role dose not support ova
2 participants
@nbeernink @maxamillion