Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No consistency between README.md and defaults/main.yml in controller_credentials role #990

Open
akira6592 opened this issue Dec 2, 2024 · 2 comments · May be fixed by #992
Open

No consistency between README.md and defaults/main.yml in controller_credentials role #990

akira6592 opened this issue Dec 2, 2024 · 2 comments · May be fixed by #992
Labels
bug Something isn't working new New issue, this should be removed once reviewed

Comments

@akira6592
Copy link
Contributor

Summary

The default value of controller_configuration_credentials_secure_logging in controller_credentials/defaults/main.yml is "{{ aap_configuration_secure_logging | default(true) }}".

But README.md says default is false.

Which is correct?

Issue Type

  • Bug Report

Ansible, Collection, Controller details

N/A (Document only)

OS / ENVIRONMENT

N/A (Document only)

Desired Behavior

N/A (Document only)

Actual Behavior

N/A (Document only)

STEPS TO REPRODUCE

N/A (Document only)

@akira6592 akira6592 added bug Something isn't working new New issue, this should be removed once reviewed labels Dec 2, 2024
@djdanielsson
Copy link
Collaborator

for credentials it is default true, I think there might be one other role that defaults true but the rest are false which is probably why it is wrong in the readme.

@akira6592
Copy link
Contributor Author

Thank you. I think so, too.

There is same problem in the eda_credentials role.

Because the *_credentials role treats a sensitive data, I think true is appropriate the default for *_credentials_secure_logging.

I'll submit a PR for fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working new New issue, this should be removed once reviewed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants