Build ODS-CI test image for release 2.16 #2131
Conversation
Robot Results
|
ods_ci/build/install_idp.sh
Outdated
| function update_test_config(){ | ||
| echo "Update test config file..." | ||
|
|
||
| AWS_SHARED_CREDENTIALS_FILE="${CLUSTER_PROFILE_DIR}/.awscred" |
There was a problem hiding this comment.
this would work only for the interop pipeline case, while this script is generic. You can add the feature if you want, but it'd be better to put it under an option of the script/env variable
ods_ci/build/install_idp.sh
Outdated
| validate_user_config_file | ||
| check_installation | ||
| install_identity_provider | ||
| update_test_config | ||
|
|
||
| echo "Performing oc login using TEST username and password" |
There was a problem hiding this comment.
the login is performed earlier in this script with htp user. Why do we need to log in with a different one?
liswang89
force-pushed
the
release-2.16
branch
5 times, most recently
from
cbc7cc2 to
ea315bc
Compare
liswang89
force-pushed
the
release-2.16
branch
from
ea315bc to
286430a
Compare
|
| @@ -0,0 +1,48 @@ | |||
| !/bin/bash | |||
There was a problem hiding this comment.
| !/bin/bash | |
| #!/bin/bash |
There was a problem hiding this comment.
|
Should we set And how it is consumed by ods-ci/ods_ci/build/install_idp.sh Line 449 in e3444d4 |
yes, you should set that env variable to zero in your job.
it's an Environment variable, so that's how install_idp.sh consumes it |
No description provided.