Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Interop testing image #2000

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

liswang89
Copy link

@liswang89 liswang89 commented Nov 4, 2024

This PR builds the ODS-CI test image for containerized interoperability testing. The image is temporarily hosted at quay.io/modh/ods-ci:dev, and there is already a mapping from Quay to the CI registry with the 'dev' tag. We can create new images based on the RHOAI release later. There are three main issues to address:

  1. Encountering a permission denied error when running tests because the test image was built and exposed with the root user.
  2. oc login fails after creating IDP test users if we set --skip-oclogin=false.
  3. Porting the ods-install scripts to create IDP users for testing."

ods_ci/build/ldap/ldap.yaml Fixed Show fixed Hide fixed
ods_ci/build/ldap/ldap.yaml Fixed Show fixed Hide fixed
ods_ci/build/ldap/ldap.yaml Fixed Show resolved Hide resolved
@liswang89 liswang89 force-pushed the test-interop branch 9 times, most recently from c477d1f to 93a2c68 Compare November 6, 2024 21:34
ods_ci/build/ldap/ldap.yaml Outdated Show resolved Hide resolved
@apodhrad apodhrad self-requested a review November 11, 2024 13:09
ods_ci/run_interop.sh Outdated Show resolved Hide resolved
ods_ci/run_interop.sh Outdated Show resolved Hide resolved
@omrirh
Copy link
Contributor

omrirh commented Nov 11, 2024

@apodhrad @liswang89 maybe we can add an additional label for Interop testing, then we could trigger this code with args via Jenkins, something like this:
$TEST_MARKER -e AutomationBug -e ProductBug -e ExcludeOnRHOAI ... -i Interop

wyt?

@bdattoma
Copy link
Contributor

Porting the ods-install scripts to create IDP users for testing."

have you considered using https://github.com/red-hat-data-services/ods-ci/blob/master/ods_ci/build/install_idp.sh? it was already used by the previous interop pipeline

@liswang89 liswang89 force-pushed the test-interop branch 2 times, most recently from 706197c to 5bd2109 Compare November 13, 2024 02:44
apodhrad
apodhrad previously approved these changes Nov 20, 2024
omrirh
omrirh previously approved these changes Nov 20, 2024
ods_ci/build/ldap/ldap.yaml Outdated Show resolved Hide resolved
ods_ci/build/ldap/ldap.yaml Fixed Show fixed Hide fixed
ods_ci/build/ldap/ldap.yaml Fixed Show fixed Hide fixed
@liswang89 liswang89 force-pushed the test-interop branch 3 times, most recently from 7757935 to 8df2fdc Compare November 22, 2024 23:04
@liswang89 liswang89 requested a review from bdattoma November 22, 2024 23:05
@liswang89 liswang89 force-pushed the test-interop branch 4 times, most recently from 9769df8 to 0b8cd8c Compare November 27, 2024 21:24
@liswang89 liswang89 force-pushed the test-interop branch 2 times, most recently from 2eaba31 to c49d80a Compare December 2, 2024 03:27
@liswang89 liswang89 force-pushed the test-interop branch 2 times, most recently from 0065a83 to 697fc49 Compare December 2, 2024 13:31
omrirh
omrirh previously approved these changes Dec 4, 2024
@liswang89 liswang89 force-pushed the test-interop branch 3 times, most recently from eb6f856 to 7a6f256 Compare December 4, 2024 15:39
labels:
app.kubernetes.io/name: openldap
spec:
containers:

Check warning

Code scanning / SonarCloud

Service account permissions should be restricted Medium

Bind this resource's automounted service account to RBAC or disable automounting. See more on SonarQube Cloud
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
586 0 0 586 100

Copy link

sonarcloud bot commented Dec 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants