Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Dockerfile.konflux #22

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Create Dockerfile.konflux #22

merged 4 commits into from
Oct 16, 2024

Conversation

MohammadiIram
Copy link
Member

@MohammadiIram MohammadiIram marked this pull request as draft October 9, 2024 11:50
@spolti
Copy link

spolti commented Oct 11, 2024

is this ready for review?

@MohammadiIram MohammadiIram marked this pull request as ready for review October 15, 2024 14:23
@MohammadiIram
Copy link
Member Author

is this ready for review?

yes, please review the PR.

RUN echo "Files to download: $PNC_FILES_JSON"

# Install packages for the install script and extract archives
RUN microdnf --setopt=install_weak_deps=0 --setopt=tsflags=nodocs install -y unzip jq wget
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we need the rpm.in and lock files to be able to install it?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it to download files from PNC?

what about the konflux cache?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where the java bits is being built?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we need the rpm.in and lock files to be able to install it?

yes, we have the rpm files added

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please clarify the other questions?

Dockerfile.konflux Outdated Show resolved Hide resolved
RUN sed -i 's:security.provider.12=SunPKCS11:#security.provider.12=SunPKCS11:g' /usr/lib/jvm/java-17-openjdk-*/conf/security/java.security \
&& sed -i 's:#security.provider.1=SunPKCS11 ${java.home}/lib/security/nss.cfg:security.provider.12=SunPKCS11 ${java.home}/lib/security/nss.cfg:g' /usr/lib/jvm/java-17-openjdk-*/conf/security/java.security

ENV JAVA_HOME=/usr/lib/jvm/jre-17-openjdk
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the base image already provides this env, IMHO, we don't need to set it here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

chown -R app:0 . && \
chmod -R 771 . && chmod 775 *.sh *.py && \
echo "${CI_CONTAINER_VERSION}" > /opt/kserve/mmesh/build-version && \
sed -i 's/security.useSystemPropertiesFile=true/security.useSystemPropertiesFile=false/g' $JAVA_HOME/conf/security/java.security
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is to disable FIPS, do we want that?

@MohammadiIram MohammadiIram merged commit c458ed7 into main Oct 16, 2024
4 checks passed


###############################################################################
#latest tag
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which is the latest tag?

please adopt a pattern. e.g.:

openjdk-17-runtime:1.17-9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants