Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync master branch with the upstream opendatahub stable branch #54

Merged
merged 5 commits into from
May 23, 2024

Conversation

harshad16
Copy link
Member

Sync master branch with the upstream opendatahub stable branch

Related-to:
https://issues.redhat.com/browse/RHOAIENG-5033
https://issues.redhat.com/browse/RHOAIENG-6617

harshad16 and others added 5 commits May 23, 2024 17:18
Fix the dpanic for log in notebook controller while injecting the
trusted CA bundle configuration.

https://issues.redhat.com/browse/RHOAIENG-5033
…stry (#332)

* Add logic on nbc-webhook to pickup internal or external registry

* create a temporary kubeconfig file for the test setup

* Pass kubeconfig as parameter,and handle the scenario of no namespaces that include the imagestream

---------

Co-authored-by: atheo89 <[email protected]>
…30-to-stable

[stable] Upgrade go version to 1.20 for notebook-controller
…31-to-stable

[stable] [RHOAIENG-5033] Odd number of arguments passed as key-value pairs for…
@openshift-ci openshift-ci bot requested review from LaVLaS and VaishnaviHire May 23, 2024 18:02
@harshad16
Copy link
Member Author

/approve
Merging this for release rhoai-2.10

@harshad16 harshad16 merged commit 8611b3a into red-hat-data-services:master May 23, 2024
5 of 7 checks passed
Copy link

openshift-ci bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants