Sync kustomization.yaml namespace with what we have in upstream #178
Conversation
The odh/rhoai operator overrides the namespace values anyway, so we should be okay. With this in sync with upstream, we reduce the code difference and will able the e2e tests to work as are defined now. We may want to rethink the e2e test env preparation in the future eventually.
yeah, should be safe; would like to see a rhoai-nightly, too bad the builds are now stopped; but even without it, yeah, let's go for it, I say /lgtm |
This comment was marked as outdated.
This comment was marked as outdated.
|
The mood shall be imperative and never other. /retitle Sync kustomization.yaml namespace with what we have in upstream
|
openshift-ci
bot
changed the title
|
/label tide/merge-method-squash I am not a fan of useless merge commits when they are useless |
|
Thanks Jan for the fix! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstourac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The odh/rhoai operator overrides the namespace values anyway, so we should be okay. With this in sync with upstream, we reduce the code difference and will able the e2e tests to work as are defined now.
We may want to rethink the e2e test env preparation in the future eventually.
This is a followup to previous sync where @jiridanek was afraid to touch the namespace, so he did not sync this line then