Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove e-mail usage #63

Open
cceckman opened this issue Aug 6, 2024 · 0 comments
Open

Remove e-mail usage #63

cceckman opened this issue Aug 6, 2024 · 0 comments
Labels
cleanup Do the same thing, but in a nicer way. good first issue Good for newcomers

Comments

@cceckman
Copy link
Collaborator

cceckman commented Aug 6, 2024

Per #55, e-mail is not a consistent identifier across Zulip and RC API. Or across Zulip in time.

After #62, the only remaining use of e-mail identifiers is in the "reviews" feature. We could replace this with Zulip IDs to make the migration away from e-mail complete.

(Note: we don't want to store names here; that might lead the review to present a name that is no longer appropriate for the reviewer.)
@cceckman cceckman added enhancement New feature or request good first issue Good for newcomers cleanup Do the same thing, but in a nicer way. and removed enhancement New feature or request labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Do the same thing, but in a nicer way. good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cceckman