[Printer] Try extends PHPStan Printer #6518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
commented
Nov 27, 2024
| @@ -295,7 +294,6 @@ public function processNodes( | |||
| $this->nodeScopeResolverProcessNodes($stmts, $scope, $nodeCallback); | |||
|
|
|||
| $nodeTraverser = new NodeTraverser(); | |||
| $nodeTraverser->addVisitor(new WrappedNodeRestoringNodeVisitor()); | |||
There was a problem hiding this comment.
@ondrejmirtes I tried remove this unwrap, and it somehow cause invalid print:
Failed on fixture file "mirror_assign_comment.php.inc"
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
{
public static function run()
{
- $response = match ($_SERVER['REQUEST_METHOD']) {
+ $response = match (__phpstanRembered($_SERVER['REQUEST_METHOD'])) {see "__phpstanRembered" printered above, and cause error:
2) Rector\Tests\CodeQuality\Rector\ClassMethod\OptionalParametersAfterRequiredRector\OptionalParametersAfterRequiredRectorTest::test with data set #7 ('/Users/samsonasik/www/rector-...hp.inc')
assert($subStartPos >= 0 && $subEndPos >= 0)
/home/runner/work/rector-src/rector-src/vendor/nikic/php-parser/lib/PhpParser/PrettyPrinterAbstract.php:688
/home/runner/work/rector-src/rector-src/src/PhpParser/Printer/BetterStandardPrinter.php:116
There was a problem hiding this comment.
@ondrejmirtes it seems __phpstanRembered string make wrapping node print, and cause above output
|
Alright, I get it. Please forget what I said, you need to unwrap the expression by yourself and the PHPStan Printer class isn't usable for your use-case. |
|
Ok, let's close then ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #6517 (comment)