Skip to content

Fix interface implementer in AddOverrideAttributeToOverriddenMethodsRector, add override only in case of overiding parent method with contents #27918

Fix interface implementer in AddOverrideAttributeToOverriddenMethodsRector, add override only in case of overiding parent method with contents

Fix interface implementer in AddOverrideAttributeToOverriddenMethodsRector, add override only in case of overiding parent method with contents #27918

Workflow file for this run

# This workflow runs system tests: Use the Rector application from the source
# checkout to process "fixture" projects in e2e/ directory
# to see if those can be processed successfully
name: End to End tests
on:
pull_request:
branches:
- main
push:
branches:
- main
env:
# see https://github.com/composer/composer/issues/9368#issuecomment-718112361
COMPOSER_ROOT_VERSION: "dev-main"
jobs:
end_to_end:
runs-on: ubuntu-latest
timeout-minutes: 3
strategy:
fail-fast: false
matrix:
php_version: ['8.2']
directory:
- 'e2e/applied-rule-change-docblock'
- 'e2e/applied-rule-return-array-nodes'
- 'e2e/no-parallel-reflection-resolver'
- 'e2e/parallel-custom-config'
- 'e2e/parallel-reflection-resolver'
- 'e2e/applied-rule-removed-node'
- 'e2e/parallel with space'
- 'e2e/different-path-over-skip-config'
- 'e2e/invalid-paths'
- 'e2e/applied-polyfill-php80'
- 'e2e/print-new-node'
name: End to end test - ${{ matrix.directory }}
steps:
- uses: actions/checkout@v4
- uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php_version }}
coverage: none
# run in root rector-src
- run: composer install --ansi
# run in e2e subdir
-
run: composer install --ansi
working-directory: ${{ matrix.directory }}
# run e2e test
- run: php ../e2eTestRunner.php --config custom/config/rector.php
working-directory: ${{ matrix.directory }}
if: ${{ matrix.directory == 'e2e/parallel-custom-config' }}
# this tests "-c", that was not working on parallel before, see https://github.com/rectorphp/rector-src/pull/1620
- run: php ../e2eTestRunner.php -c custom/config/rector.php
working-directory: ${{ matrix.directory }}
if: ${{ matrix.directory == 'e2e/parallel-custom-config' }}
- run: php ../e2eTestRunner.php
working-directory: ${{ matrix.directory }}
if: ${{ matrix.directory != 'e2e/parallel-custom-config' }}