[CodeQuality] Skip call parent::__construct() indirect parent on ConstructClassMethodToSetUpTestCaseRector

phpunit.xml

@@ -8,6 +8,7 @@
     <testsuites>
         <testsuite name="main">
             <directory>tests</directory>
+            <directory>rules-tests</directory>
             <exclude>tests/Rector/Class_/AddSeeTestAnnotationRector/Source</exclude>
             <exclude>tests/Rector/ClassMethod/DependsAnnotationWithValueToAttributeRector/Source</exclude>
         </testsuite>

rules-tests/CodeQuality/Rector/Class_/ConstructClassMethodToSetUpTestCaseRector/Fixture/skip_call_parent_construct_exists.php.inc

@@ -0,0 +1,17 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\ConstructClassMethodToSetUpTestCaseRector\Fixture;
+
+use Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\ConstructClassMethodToSetUpTestCaseRector\Source\TestResponse;
+
+final class SkipCallParentConstructExists extends TestResponse
+{
+    private $someValue;
+
+    public function __construct()
+    {
+        $this->someValue = 1000;
+
+        parent::__construct();
+    }
+}

rules-tests/CodeQuality/Rector/Class_/ConstructClassMethodToSetUpTestCaseRector/Fixture/skip_parameter_used.php.inc

@@ -0,0 +1,18 @@
+<?php
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\ConstructClassMethodToSetUpTestCaseRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+final class SkipParameterUsed extends TestCase
+{
+    public function __construct($param)
+    {
+        $this->initEarly($param);
+    }
+
+    private function initEarly($param)
+    {
+        echo 'init';
+    }
+}

rules-tests/CodeQuality/Rector/Class_/ConstructClassMethodToSetUpTestCaseRector/Source/TestResponse.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\PHPUnit\Tests\CodeQuality\Rector\Class_\ConstructClassMethodToSetUpTestCaseRector\Source;
+
+use PHPUnit\Framework\TestCase;
+
+abstract class TestResponse extends TestCase
+{
+    public function __construct()
+    {
+        echo "init";
+    }
+}

rules/CodeQuality/Rector/ClassMethod/RemoveEmptyTestMethodRector.php

@@ -8,6 +8,7 @@
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\NodeTraverser;
 use Rector\Core\Rector\AbstractRector;
+use Rector\Core\Util\StringUtils;
 use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@@ -66,7 +67,7 @@ public function refactor(Node $node): ?int
             return null;
         }
 
-        if (! $this->isName($node->name, 'test*')) {
+        if (! fnmatch('test*', $node->name->toString(), FNM_NOESCAPE)) {
             return null;
         }
 

rules/CodeQuality/Rector/ClassMethod/ReplaceTestAnnotationWithPrefixedFunctionRector.php

@@ -9,6 +9,7 @@
 use PhpParser\Node\Stmt\ClassMethod;
 use Rector\BetterPhpDocParser\PhpDocManipulator\PhpDocTagRemover;
 use Rector\Core\Rector\AbstractRector;
+use Rector\Core\Util\StringUtils;
 use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@@ -71,7 +72,7 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        if ($this->isName($node->name, 'test*')) {
+        if (fnmatch('test*', $node->name->toString(), FNM_NOESCAPE)) {
             return null;
         }
 

rules/CodeQuality/Rector/Class_/PreferPHPUnitThisCallRector.php

@@ -12,6 +12,7 @@
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\NodeTraverser;
 use Rector\Core\Rector\AbstractRector;
+use Rector\Core\Util\StringUtils;
 use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@@ -94,7 +95,7 @@ public function refactor(Node $node): ?Node
                 return null;
             }
 
-            if (! $this->isName($node->name, 'assert*')) {
+            if (! fnmatch('assert*', $methodName, FNM_NOESCAPE)) {
                 return null;
             }
 

rules/PHPUnit70/Rector/Class_/RemoveDataProviderTestPrefixRector.php

@@ -9,6 +9,7 @@
 use PhpParser\Node\Identifier;
 use PhpParser\Node\Stmt\Class_;
 use Rector\Core\Rector\AbstractRector;
+use Rector\Core\Util\StringUtils;
 use Rector\PHPUnit\NodeAnalyzer\TestsNodeAnalyzer;
 use Rector\PHPUnit\NodeFinder\DataProviderClassMethodFinder;
 use Rector\PHPUnit\PhpDoc\DataProviderMethodRenamer;
@@ -96,7 +97,7 @@ public function refactor(Node $node): ?Node
 
         $dataProviderClassMethods = $this->dataProviderClassMethodFinder->find($node);
         foreach ($dataProviderClassMethods as $dataProviderClassMethod) {
-            if (! $this->isName($dataProviderClassMethod, 'test*')) {
+            if (! fnmatch('test*', $dataProviderClassMethod->name->toString(), FNM_NOESCAPE)) {
                 continue;
             }
 

src/NodeAnalyzer/TestsNodeAnalyzer.php

@@ -53,7 +53,7 @@ public function isTestClassMethod(ClassMethod $classMethod): bool
             return false;
         }
 
-        if ($this->nodeNameResolver->isName($classMethod, 'test*')) {
+        if (fnmatch('test*', $classMethod->name->toString(), FNM_NOESCAPE)) {
             return true;
         }