Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shouldn't it be DoctrineSetList::DOCTRINE_ORM_219? #306

Open
mvhirsch opened this issue Apr 9, 2024 · 0 comments
Open

Shouldn't it be DoctrineSetList::DOCTRINE_ORM_219? #306

mvhirsch opened this issue Apr 9, 2024 · 0 comments

Comments

@mvhirsch
Copy link

mvhirsch commented Apr 9, 2024

As the Lexer::* consts got deprecated in v2.19 and the current naming scheme in DoctrineSetList would suggest using _219 (as _214 exists for 2.14).

Shouldn't this be renamed then? https://github.com/rectorphp/rector-doctrine/blob/b3da143634de79b24a266afc07401cfe75a2c49c/config/sets/doctrine-orm-29.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mvhirsch