Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ssh-agent and forwarding? #12

Open
rupor-github opened this issue Aug 3, 2016 · 17 comments
Open

Support for ssh-agent and forwarding? #12

rupor-github opened this issue Aug 3, 2016 · 17 comments

Comments

@rupor-github
Copy link

Hi, are there any plans to support this?

@seletskiy
Copy link
Member

@rupor-github: Hi! Not yet. It was already mentioned in the #10. I'l glad to merge PR with ssh-agent support.

@rupor-github
Copy link
Author

Here you are: #14

@rupor-github
Copy link
Author

@seletskiy did you have a chance to look at my pool requests (both runcmd and orgalorg)?

@seletskiy
Copy link
Member

@rupor-github: Sorry, I was little bit of out context lately. I will take a close look soon. Thanks for poking me.

@linuxbsdfreak
Copy link

linuxbsdfreak commented Apr 23, 2018

@seletskiy - Do you know if this can be merged? I am using the orgalorg tool and would like to use the ssh-agent withougt entering the passphrase everytime.

@prologic
Copy link

prologic commented Feb 8, 2019

Looks like the PR never got merged. What happening here?

@seletskiy
Copy link
Member

@prologic it seems that runcmd library repo was lost along with required PR, so author closed PR.

We need to restore this feature in runcmd first.

@prologic
Copy link

prologic commented Feb 8, 2019

This was some years ago... Is there still interest in adding this feature? I'm not seeing much evidence of activity on this project of late... Do you still actively maintain/develop it?

@seletskiy
Copy link
Member

@prologic: well, I do not use orgalorg right now, but that doesn't mean, that project is dead.
If someone will add agent functionality back in runcmd then I will gladly merge PR #14.

@kovetskiy
Copy link
Member

@prologic yes, I use the program on an everyday basis, the thing about it is that it just works fine.

@tbellembois
Copy link

I undig a very old topic.

Is there any possibility to use the https://godoc.org/golang.org/x/crypto/ssh library instead of runcmd ?
runcmd does not look to be maintained.

@kovetskiy
Copy link
Member

@tbellembois what point do you see in it? The runcmd package doesn't do anything except wrapping golang.org/x/crypto/ssh, providing an interface which we use in orgalorg itself as abstraction layer for Local/Remote runners.

@kovetskiy
Copy link
Member

@tbellembois nevermind, I've already forked runcmd and reworked it a bit.

Also, I've added support of ssh-agent here: ed1e994

@seletskiy
Copy link
Member

flash
@kovetskiy

@tbellembois
Copy link

Orgalorg keeps asking for my ssh keys.
Changing the main.go file into (line 707):

	if os.Getenv("SSH_AUTH_SOCK") != "" {
		sock, err := net.Dial("unix", os.Getenv("SSH_AUTH_SOCK"))
		if err != nil {
			return nil, hierr.Errorf(
				err,
				"unable to dial to ssh agent socket: %s",
				os.Getenv("SSH_AUTH_SOCK"),
			)
		}

		keyring = agent.NewClient(sock)
	} else {
		keyring = agent.NewKeyring()
	}

does the job but not sure this is the right think to do...

@seletskiy
Copy link
Member

@tbellembois feel free to open pull request!

@tbellembois
Copy link

Done ! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants