Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

adding bindings to HtmlVideoElement #173

Open
BlueHotDog opened this issue Apr 12, 2020 · 3 comments · May be fixed by #196
Open

adding bindings to HtmlVideoElement #173

BlueHotDog opened this issue Apr 12, 2020 · 3 comments · May be fixed by #196
Labels
enhancement help wanted

Comments

@BlueHotDog
Copy link

Hi, I want to add bindings to HtmlVideoElement(defined here: https://developer.mozilla.org/en-US/docs/Web/API/HTMLVideoElement). seems like there's a missing bindings for HtmlMediaElement(also the type is missing on Ocaml Dom).
Should i take a stab at it?
If so, how would i do that without the relevant ocaml type?
@glennsl
Copy link
Member

glennsl commented Apr 13, 2020

Yeah, that would be great. You can just use a local type t for now, as well as submit a PR to bs-platform to add it to Dom. Once that's been merged and released we can link the local t type to that, and it won't even be a breaking change (other than requiring an updated bs-platform).

@illusionalsagacity
Copy link
Contributor

I have a PR up for rescript-compiler to add the phantom type to Dom. @BlueHotDog are you working on this? If not I can

@BlueHotDog
Copy link
Author

hey, i'm not working on this :) feel free to PR :)

@illusionalsagacity illusionalsagacity linked a pull request Aug 20, 2020 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
4 participants
@yawaramin @BlueHotDog @illusionalsagacity @glennsl